Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove includes if not necessary #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drhideg
Copy link
Contributor

@drhideg drhideg commented May 24, 2021

This patch can save about 700 byte RAM and about 14kB Flash space (compiled with ESP8266):

REPO defaults:

    RAM:   [=====     ]  52.3% (used 42860 bytes from 81920 bytes)
    Flash: [=====     ]  51.5% (used 526888 bytes from 1023984 bytes)
    Compression reduced firmware size by 71% (was 531040 bytes, now 379676 bytes)

REPO check/unckeck energysensors and displays /still use USE_I2C, USE_SPI, USE_ENERGY_SENSOR/:

    RAM:   [=====     ]  53.2% (used 43548 bytes from 81920 bytes)
    Flash: [=====     ]  52.8% (used 540852 bytes from 1023984 bytes)
    Compression reduced firmware size by 71% (was 545008 bytes, now 389246 bytes)

PATCH defaults:

    RAM:   [=====     ]  52.3% (used 42860 bytes from 81920 bytes)
    Flash: [=====     ]  51.5% (used 526888 bytes from 1023984 bytes)
    Compression reduced firmware size by 71% (was 531040 bytes, now 379676 bytes)

PATCH check/unckeck energysensors and displays /remove USE_I2C, USE_SPI, USE_ENERGY_SENSOR/:

    RAM:   [=====     ]  52.3% (used 42860 bytes from 81920 bytes)
    Flash: [=====     ]  51.5% (used 526888 bytes from 1023984 bytes)
    Compression reduced firmware size by 71% (was 531040 bytes, now 379673 bytes)

@bovirus
Copy link
Contributor

bovirus commented Jun 20, 2022

@benzino77

Could pelase consider if leave it open or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants