Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GitLab workspace integration #1523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProbablyFaiz
Copy link

Changed getTree to a recursive function so it iterates through all pages of the GitLab API's response when fetching the tree. Fixes #1462 and #1505 for real this time.

Changed getTree to a recursive function so it iterates through all pages of the GitLab API's response when fetching the tree.
@dcbaker
Copy link

dcbaker commented May 7, 2021

I applied this patch and can confirm that this fixes #1629 . Is there any chance of this landing and being added to a release?

@lorenx
Copy link

lorenx commented Aug 11, 2021

I applied this patch and can confirm that this fixes #1629 . Is there any chance of this landing and being added to a release?

Maybe not though, me and other people are still experiencing file mysteriously disappearing.

@lorenx
Copy link

lorenx commented Aug 12, 2021

I've just found out something.
In my case, it seems there's a visibility limit up to 80 files/pages.

I have 89 pages at this moment and now I understand why I started to notice the issue.
Since files don't disappear from the repo itself (fortunately), I could compare and note down the missing files.
Then I continued to work for a while and I had to create another page. Suddenly I realized I lost another file so I wanted to test it better this time: I deleted an old file (I also had to empty the trash with a forced push, or files wouldn't decrease) and boom, the last file I lost appeared back, exactly the last one which disappeared (as if there's a sort of order).

Well, in my case it seems there's a files visibility limit (and it's 80), does it makes sense?

@dcbaker
Copy link

dcbaker commented Aug 13, 2021

Yes, as is stackedit tries to create a list of 9999 items (IIRC), but gitlab well silently cap that. With this patch (which is not in master), it parses additional pages, thus fixing the issue. I've pretty much given up on stackedit though, it seems abandoned, and it needs do much work to update dependencies with gaping security holes

@lorenx
Copy link

lorenx commented Aug 13, 2021

@dcbaker Yeah, but it's a pity...
Can I ask what are you using now?

@dcbaker
Copy link

dcbaker commented Aug 31, 2021

@lorenx, sorry, I do development on github and get a lot of messages. I've been using dillinger.io, but github intergration is broken there too now, so I've just been using the gitlab online editor. It's not great, but at least it keeps working...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab workspace integration broken
3 participants