Support for Adding Multiple Groups #1349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfiniteCoder06
force-pushed
the
feature-multi-group
branch
2 times, most recently
from
70983e2
to
97e4d65
Compare
|
Alex Bakker, Review whenever free |
alexbakker
requested changes
Jun 1, 2024
There was a problem hiding this comment.
Nice work! I've added a couple of comments.
This suffers from the same issue you're trying to solve in #1354, but we can apply the same fix here later once we've found a suitable one.
|
Now that #1354 is merged, there are some conflicts. |
InfiniteCoder06
force-pushed
the
feature-multi-group
branch
from
97e4d65
to
c11a31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #27, This can be done by using MultiAutoCompleteTextView, but This implementation is inspired from Google Contacts app (Labels)