New Theme Colour Structure. Replacing hard coded colours in IDE with variables #1153
+1,545
−595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GetNames, GetValues and Count methods
Additional Type Checking
Base structure for new IDE Colour handling. Will allow for multiple Colour sections in the theme.toml file Part of the project to replace all hard coded colours in the IDE with variables
This implements the new Theme Colour structure on top of the existing structure. This is to minimise the number of code changes in one commit
…eColours New Theme Colour Structure. Part I
Use Default Colours when no Theme specified
No need to Set defaults. Handled in ThemeColors
Split Colors into Colors & Theme Replace DarkTheme.COLOR_... with ThemeColors.Theme..Color
Removed separate color array and replaced with reference to ThemeColors static array element
The vast majority of hard coded colours have been replaced with variables. Refer to Beefy2D/src//theme/ThemeColors.bf
SteveSmithSoftware
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GetNames, GetValues and Count methods