Add clear de/serialization for #causal/base tagged literal #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobby
commented
Mar 18, 2020
|
|
||
| #? (:cljs (cljs.reader/register-tag-parser! 'causal.collections.list read-edn-map)) |
There was a problem hiding this comment.
@smothers This seemed like an error, so I replaced it with a 'causal/base tag parser. Will this break anything?
There was a problem hiding this comment.
This is indeed a bug. Good catch. This code was never tested so it shouldn’t break anything important. Everything important should have tests.
|
This PR appears to be working in my app. |
|
Looks good. Please add some tests and then it’ll be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.