Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create stub app for admin frontend #500

Merged
merged 35 commits into from
May 28, 2024
Merged

Conversation

banders
Copy link
Contributor

@banders banders commented May 22, 2024

Description

Copied the 'frontend' folder to 'admin-frontend' as a starting point for the upcoming admin application. Made changes to the Github workflows, Helm charts and environment vars specific to the admin app. Updated the backend with a new express "app" to handle IDIR login for the admin application.

Some of the source code and components copied from the frontend probably won't be needed in the admin application, and can be deleted or modified in a future PR.

Fixes # GEO-637

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Most of the unit tests from the frontend have been copied into the 'admin-frontend' app.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

backend/src/admin-app.ts Fixed Show fixed Hide fixed
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency backend-external'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency Frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Failed Quality Gate failed for 'Pay Transparency Backend'

Failed conditions
6.6% Coverage on New Code (required ≥ 80%)
42.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'Pay Transparency doc-gen-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sukanya-rath sukanya-rath merged commit 8aa7a55 into main May 28, 2024
25 of 36 checks passed
@sukanya-rath sukanya-rath deleted the feat/stub-admin-frontend branch May 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants