Allow to collect resources from objc_library implementation_deps #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-golub
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins,
thii and
mattrobmattrob
as code owners
|
Are there some tests you can change or add to make sure we don't regress this? |
brentleyjones
approved these changes
May 23, 2023
Great suggestion. Added |
mattrobmattrob
approved these changes
May 24, 2023
| inherited_providers = [] | ||
| provider_deps = ["deps"] + collect_args.get("res_attrs", []) | ||
| provider_deps = ["deps"] + ["implementation_deps"] + collect_args.get("res_attrs", []) |
There was a problem hiding this comment.
Any reason to not simplify this list addition?
Suggested change
| provider_deps = ["deps"] + ["implementation_deps"] + collect_args.get("res_attrs", []) | |
| provider_deps = ["deps", "implementation_deps"] + collect_args.get("res_attrs", []) |
| mkdir -p app/shared_res | ||
| echo shared_res > app/shared_res/foo.txt | ||
|
|
||
| do_build ios //app:app || fail "Should build" |
There was a problem hiding this comment.
[nit]
Suggested change
| do_build ios //app:app || fail "Should build" | |
| do_build ios //app:app || fail "Should build" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With bazelbuild/bazel#17962 implementation deps is another potential source of resources so need to be handled in aspect