Remove support to propagate frameworks via objc_library.runtime_deps #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support to propagate Apple frameworks (ie. `ios_framework`, `tvos_framework`) through the `data` attribute from transitive libraries (ie. `objc_library` and `swift_library`) using the resource aspect. Currently, Apple frameworks (`*_framework` targets) are supported using the `runtime_deps` attribute for `objc_library` targets through the framework provider aspect (support was added at 1199da0 and 889131a). This support will be deprecated on a follow-up change. PiperOrigin-RevId: 513139752 (cherry picked from commit f711be0)
…e_deps This only takes the tests from the cherry picked commit to maintain untested backwards compatibility until we drop bazel 6.x support f711be0 added support to propagate Apple frameworks using `data` rule attribute for both objc_library and swift_library targets. This change now removes support to propagate frameworks via `runtime_deps`. PiperOrigin-RevId: 514762665 (cherry picked from commit 7d0ec13)
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
|
can't do this until we want to no longer support runtime_deps |
keith
referenced
this pull request
Mar 21, 2023
f711be0 added support to propagate Apple frameworks using `data` rule attribute for both objc_library and swift_library targets. This change now removes support to propagate frameworks via `runtime_deps`. PiperOrigin-RevId: 514762665
This fixes the watchos_extension case, but isn't how ios_extensions work, so remove my WIP test for that
…cts. Current logic incorrectly assumes `files` is a single framework, and thus bundles all frameworks to the same location. If there are multiple frameworks bundled, the partial should iterate each bundle and source the correct bundle name to set as a parent directory when tree artifacts are enabled. PiperOrigin-RevId: 514821470 (cherry picked from commit 644face)
This reverts commit 459b62f.
keith
force-pushed
the
ks/remove-support-to-propagate-frameworks-via-objc_library.runtime_deps
branch
from
bb5b2bb
to
a4ff994
Compare
keith
force-pushed
the
ks/support-propagating-frameworks-via-objc-swift_library-data-attribute
branch
from
10c3608
to
6911fe6
Compare
Base automatically changed from
ks/support-propagating-frameworks-via-objc-swift_library-data-attribute
to
master
April 3, 2023 23:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f711be0 added support to propagate Apple frameworks using
datarule attribute for both objc_library and swift_library targets. This
change now removes support to propagate frameworks via
runtime_deps.PiperOrigin-RevId: 514762665
(cherry picked from commit 7d0ec13)