feat: support custom CA for redis TLS #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werkt
reviewed
May 22, 2024
| * @return A builder with the SSL context attached. | ||
| * @note Suggested return identifier: builder. | ||
| */ | ||
| private static DefaultJedisClientConfig.Builder attachSslSocketFactoryIfNeeded( |
There was a problem hiding this comment.
can we break this out into a separate RedisSSL.java? - it pollutes the namespace of this file substantially and has only static methods to show for it - I'm picturing one road in with the cert file, and one road out with the authentication adapter.
There was a problem hiding this comment.
Sure - shall I place it under src/main/java/build/buildfarm/common/redis/RedisSSL.java ?
jasonschroeder-sfdc
force-pushed
the
redis-tls
branch
2 times, most recently
from
58ea885
to
22d6aa5
Compare
werkt
reviewed
May 23, 2024
src/main/java/build/buildfarm/instance/shard/JedisClusterFactory.java
Outdated
Show resolved
Hide resolved
werkt
approved these changes
May 23, 2024
This is to support Google MemoryStore in-transit encryption.
Add documentation for `redisCertificateAuthorityFile` and reflow the Markdown table.
jasonschroeder-sfdc
force-pushed
the
redis-tls
branch
from
22d6aa5
to
a1f672d
Compare
werkt
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support Google MemoryStore in-transit encryption.
Fixes: #1643