Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/build: filter out private functions #335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itsjfx
Copy link
Contributor

@itsjfx itsjfx commented Mar 3, 2023

I can't say I'm proud of this patch... the grep isn't great
feedback on how to make it better would be appreciated

this should filter out private functions from the bash completion which naturally float to the top of the completion list

I find myself using the bma command a lot cause I can't remember the names of the commands

before:
before patch

after:
after patch

@itsjfx itsjfx requested a review from mbailey as a code owner March 3, 2023 02:18
@itsjfx itsjfx force-pushed the dont-complete-private-functions branch from e69c839 to d7b8fdd Compare March 3, 2023 02:20
@itsjfx itsjfx force-pushed the dont-complete-private-functions branch from 01a6e63 to d217e73 Compare March 3, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant