expose cookie options (#51)

* expose cookie options * changeset
basementstudio · Jun 26, 2023 · f2c1a3c · f2c1a3c · vercel · Jun 26, 2023
1 parent bcf244b
commit f2c1a3c
Show file tree

Hide file tree

Showing 7 changed files with 47 additions and 12 deletions.
diff --git a/.changeset/cold-vans-provide.md b/.changeset/cold-vans-provide.md
@@ -0,0 +1,5 @@
+---
+'@bsmnt/storefront-hooks': patch
+---
+
+Expose cookie options
diff --git a/packages/hooks/src/helpers/use-cart-cookie-manager.ts b/packages/hooks/src/helpers/use-cart-cookie-manager.ts
@@ -3,15 +3,19 @@ import * as React from 'react'
 
 import { isClient } from './misc'
 
-export const useCartCookieManager = (key: string) => {
+export const useCartCookieManager = (
+ key: string,
+ opts?: Cookies.CookieAttributes
+) => {
  return React.useMemo(() => {
  return {
  set: (id: string) => {
  if (!isClient) return
  Cookies.set(key, id, {
  sameSite: 'strict',
  secure: true,
- expires: 365 // one year
+ expires: 365, // one year
+ ...opts
  })
  },
  get: () => {
@@ -23,5 +27,5 @@ export const useCartCookieManager = (key: string) => {
  return Cookies.remove(key)
  }
  }
- }, [key])
+ }, [key, opts])
 }
diff --git a/packages/hooks/src/mutations/add-lines.ts b/packages/hooks/src/mutations/add-lines.ts
@@ -17,7 +17,8 @@ export const useAddLineItemsToCartMutation = <Cart extends BarebonesCart>({
  mutators,
  cartCookieKey,
  options,
- logging
+ logging,
+ cartCookieOptions
 }: {
  mutators: Pick<
  CartMutators<Cart>,
@@ -26,8 +27,12 @@ export const useAddLineItemsToCartMutation = <Cart extends BarebonesCart>({
  cartCookieKey: string
  options: InternalOptions<Cart>
  logging?: Logging<Cart>
+ cartCookieOptions?: Cookies.CookieAttributes
 }) => {
- const cartCookieManager = useCartCookieManager(cartCookieKey)
+ const cartCookieManager = useCartCookieManager(
+ cartCookieKey,
+ cartCookieOptions
+ )
  const optimisticCartUpdate = useOptimisticCartUpdate<Cart>()
 
  return useMutation(

diff --git a/packages/hooks/src/mutations/remove-lines.ts b/packages/hooks/src/mutations/remove-lines.ts
@@ -17,14 +17,19 @@ export const useRemoveLineItemsFromCartMutation = <Cart extends BarebonesCart>({
  mutators,
  cartCookieKey,
  options,
- logging
+ logging,
+ cartCookieOptions
 }: {
  mutators: Pick<CartMutators<Cart>, 'removeLineItemsFromCart'>
  cartCookieKey: string
  options: InternalOptions<Cart>
  logging?: Logging<Cart>
+ cartCookieOptions?: Cookies.CookieAttributes
 }) => {
- const cartCookieManager = useCartCookieManager(cartCookieKey)
+ const cartCookieManager = useCartCookieManager(
+ cartCookieKey,
+ cartCookieOptions
+ )
  const optimisticCartUpdate = useOptimisticCartUpdate<Cart>()
 
  return useMutation(

diff --git a/packages/hooks/src/mutations/update-lines.ts b/packages/hooks/src/mutations/update-lines.ts
@@ -17,14 +17,19 @@ export const useUpdateLineItemsInCartMutation = <Cart extends BarebonesCart>({
  mutators,
  cartCookieKey,
  options,
- logging
+ logging,
+ cartCookieOptions
 }: {
  mutators: Pick<CartMutators<Cart>, 'updateLineItemsInCart'>
  cartCookieKey: string
  options: InternalOptions<Cart>
  logging?: Logging<Cart>
+ cartCookieOptions?: Cookies.CookieAttributes
 }) => {
- const cartCookieManager = useCartCookieManager(cartCookieKey)
+ const cartCookieManager = useCartCookieManager(
+ cartCookieKey,
+ cartCookieOptions
+ )
  const optimisticCartUpdate = useOptimisticCartUpdate<Cart>()
 
  return useMutation(

diff --git a/packages/hooks/src/queries/cart.ts b/packages/hooks/src/queries/cart.ts
@@ -26,15 +26,20 @@ export const useCartQuery = <Cart extends BarebonesCart>({
  mutators,
  cartCookieKey,
  options,
- logging
+ logging,
+ cartCookieOptions
 }: {
  fetchCart: CartFetcher<Cart | null>
  mutators: Pick<CartMutators<Cart>, 'createCart'>
  cartCookieKey: string
  options: Options<Cart>
  logging?: Logging<Cart>
+ cartCookieOptions?: Cookies.CookieAttributes
 }) => {
- const cartCookieManager = useCartCookieManager(cartCookieKey)
+ const cartCookieManager = useCartCookieManager(
+ cartCookieKey,
+ cartCookieOptions
+ )
 
  const createCart = React.useCallback(async () => {
  const { data, userErrors, silenceUserErrors } = await mutators.createCart()

diff --git a/packages/hooks/src/storefront-hooks.tsx b/packages/hooks/src/storefront-hooks.tsx
@@ -89,7 +89,8 @@ export function createStorefrontHooks<Cart extends BarebonesCart>({
  createCartIfNotFound,
  queryClientConfig,
  cartOpenStateOptions,
- logging
+ logging,
+ cartCookieOptions
 }: {
  cartCookieKey: string
  fetchers: {
@@ -100,6 +101,7 @@ export function createStorefrontHooks<Cart extends BarebonesCart>({
  queryClientConfig?: QueryClientConfig
  cartOpenStateOptions?: cartOpenState.UseCartOpenStateOptions
  logging?: Logging<Cart>
+ cartCookieOptions?: Cookies.CookieAttributes
 }) {
  const queryClient = new QueryClient(queryClientConfig)
 
@@ -112,6 +114,7 @@ export function createStorefrontHooks<Cart extends BarebonesCart>({
  useCartQuery: (options?: cartQuery.UseCartQueryUserOptions<Cart>) => {
  return cartQuery.useCartQuery({
  cartCookieKey,
+ cartCookieOptions,
  fetchCart: fetchers.fetchCart,
  mutators: { createCart: mutators.createCart },
  options: {
@@ -135,6 +138,7 @@ export function createStorefrontHooks<Cart extends BarebonesCart>({
  createCartWithLines: mutators.createCartWithLines
  },
  cartCookieKey,
+ cartCookieOptions,
  options: { ...options },
  logging
  })
@@ -145,6 +149,7 @@ export function createStorefrontHooks<Cart extends BarebonesCart>({
  return updateLines.useUpdateLineItemsInCartMutation<Cart>({
  mutators: { updateLineItemsInCart: mutators.updateLineItemsInCart },
  cartCookieKey,
+ cartCookieOptions,
  options: {
  ...options,
  mutationOptions: options?.mutationOptions
@@ -158,6 +163,7 @@ export function createStorefrontHooks<Cart extends BarebonesCart>({
  return removeLines.useRemoveLineItemsFromCartMutation<Cart>({
  mutators: { removeLineItemsFromCart: mutators.removeLineItemsFromCart },
  cartCookieKey,
+ cartCookieOptions,
  options: {
  ...options,
  mutationOptions: options?.mutationOptions