-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: bal 1880 ongoing moitoring alerts v2 new mapping #2307
base: bal-1880-ongoing-moitoring-alerts
Are you sure you want to change the base?
WIP: bal 1880 ongoing moitoring alerts v2 new mapping #2307
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
PR Description updated to latest commit (75229c0) |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Type
enhancement, bug_fix
Description
OngoingMarchentAlert
andTransactionAlert
.Alert
table and added new ones to support the updated structure.Changes walkthrough
migration.sql
Database Schema Update for Alert Table and New Related Tables
services/workflows-service/prisma/migrations/20240416131447_alert_new_mapping_by_instance/migration.sql
businessId
andcounterpartyId
from theAlert
table.ongoingMarchentAlertId
andtransactionAlertId
to theAlert
table.OngoingMarchentAlert
andTransactionAlert
withappropriate constraints.
structure.
schema.prisma
Prisma Schema Updates for New Alert Management Structure
services/workflows-service/prisma/schema.prisma
Alert
model to reference newOngoingMarchentAlert
andTransactionAlert
models instead of direct business and counterpartyrelations.
OngoingMarchentAlert
andTransactionAlert
with fieldsand relations.
Business
andCounterparty
models to reflect newalert structures.