Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP|Draft feat: open telemetry support #1530

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

liorzam
Copy link
Collaborator

@liorzam liorzam commented Oct 31, 2023

Description

Elaborate on the subject, motivation, and context.

Related issues

  • Provide a link to each related issue.

Breaking changes

  • Describe the breaking changes that this pull request introduces.

How these changes were tested

  • Describe the tests that you ran to verify your changes, including devices, operating systems, browsers and versions.

Examples and references

  • Links, screenshots, and other resources related to this change.

Checklist

  • [] I have read the contribution guidelines of this project
  • [] I have read the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings and errors
  • [] New and existing tests pass locally with my changes

Copy link

linear bot commented Oct 31, 2023

BAL-343 ClipsPay - Observability and Quality

User story in Notion

New scope

  • Sentry in collection flow - V
  • Failed workflow, alert + observability (alert in slack)
  • Backoffice sentry
  • /run endpoint observability and error handling
  • Add context (we already have another tech debt tasks)
  • Webhook issue observablity

Definition of Done

  • ?

Technical Implementation Details

  • Create a slack channel called #critical_alerts
  • Create a Lambda function / API endpoint that will receive requests to send alerts
  • Create a service that deploys messages to a Slack channel
  • Create an object that will hold known errors and their data (text, slack channel, etc.), and use it when deploying messages to Slack

Error Scenarios

  • Received an unknown error

Tests

  • ?

Integration with Dependencies

  • Slack
  • Backoffice (firing alerts)
  • Workflows Service (if going with slack channel - firing alerts)

Documentation needed

  • ?

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: e3cab27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sweep-ai
Copy link

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants