Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate .NET code analysis #48

Merged
merged 19 commits into from
Jan 31, 2024

Conversation

Regenhardt
Copy link

Taken from the open BaGet PR loic-sharma#784

@FroggieFrog
Copy link

According to the build workflow, there is still one issue left:
grafik

@FroggieFrog
Copy link

Maybe you can integrate 2 more changes from PR #46 (then #46 is superfluous and can be closed)

  1. in src/BaGetter.Core/Entities/Converters/StringArrayToJsonConverter.cs: line 14 v => (!string.IsNullOrEmpty(v)) ? JsonConvert.DeserializeObject<string[]>(v) : Array.Empty<string>())
  2. in tests/BaGetter.Tests/HostIntegrationTests.cs: line 65 .CreateHostBuilder(Array.Empty<string>())

@FroggieFrog FroggieFrog mentioned this pull request Jan 31, 2024
@seriouz
Copy link

seriouz commented Jan 31, 2024

@Regenhardt Can you merge?

@Regenhardt Regenhardt merged commit 77fef8d into bagetter:main Jan 31, 2024
1 check passed
@Regenhardt Regenhardt deleted the feature/code-analysis branch February 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants