fix: dynamic import of vite

[alper98]

Hey, I just made a Pull Request!

Fixes #24678

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/cli	packages/cli	patch	v0.26.5-next.1

[Rugvip]

Thank you! 👍

[Rugvip]

Do you know if there's any particular version of vite where the behavior changes? Thinking it would be good if we could highlight that in the changeset. What version are you testing with?

[alper98]

Testing with these versions

"@vitejs/plugin-react": "^4.0.4",
"vite": "^4.4.9",
"vite-plugin-html": "^3.2.0",
"vite-plugin-node-polyfills": "^0.21.0"

[alper98]

Which seems to match the backstage cli vite versions:

backstage/packages/cli/package.json

Lines 193 to 196 in 95ee6d6

	"@vitejs/plugin-react": "^4.0.4",
	"vite": "^4.4.9",
	"vite-plugin-html": "^3.2.0",
	"vite-plugin-node-polyfills": "^0.21.0"

[Rugvip]

Which version is it actually resolved to though in yarn.lock?

[alper98]

our own backstage instance:

└─ app@workspace:packages/app
   └─ vite@npm:4.5.3 [f87a9] (via npm:^4.4.9 [f87a9])

while in my fork on this branch:

├─ @backstage/cli@workspace:packages/cli [05476]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [07278]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [11fe3]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [31634]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [39bca]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [70735]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [aad9f]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [b9c15]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ @backstage/cli@workspace:packages/cli [c856b]
│  └─ vite@npm:4.5.3 [23bd4] (via npm:^4.4.9 [23bd4])
│
├─ example-app-next@workspace:packages/app-next
│  └─ vite@npm:4.5.3 [d47fc] (via npm:^4.4.9 [d47fc])
│
└─ example-app@workspace:packages/app
   └─ vite@npm:4.5.3 [d47fc] (via npm:^4.4.9 [d47fc])

[benjdlambert]

I wonder if we should actually bite the bullet and bump to vite@v5? Version 6 is on it's way soon, and from what I can tell I don't think that there's any breaking changes that we would run into.

[benjdlambert]

I tried a bump to vite@5 but ran into this: rollup/rollup#5199 which the fixes are not really fixes. Not sure we can do moduleResolution: "bundler" either.

[Rugvip]

Let's 👍

[github-actions]

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.27.0 release, scheduled for Tue, 14 May 2024.

[github-actions]

Uffizzi Cluster pr-24745 was deleted.