add evaluation watcher and enable atomic enqueues #3998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places we update the state of jobs or executions, create an evaluation, and then enqueue the evaluation to the broker. The creation and enqueue of evaluations is not atomic. This can result in a lot of edge cases and potentially dangling or stale jobs and executions due to failure to trigger their re-evaluation.
This PR fixes this by implementing a data store watcher the listens for created evaluations and auto-enqueue those evaluations to the broker.
What is left is backfill of non-terminal evaluations at startup which will be tracked by #3999
Closes #3972