Move all runtime helpers to individual files #16495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
nicolo-ribaudo
commented
May 15, 2024
packages/babel-runtime/package.json
Outdated
| @@ -26,6 +26,15 @@ | |||
| "./helpers/AsyncGenerator.js" | |||
| ], | |||
| "./helpers/esm/AsyncGenerator": "./helpers/esm/AsyncGenerator.js", | |||
| "./helpers/AwaitValue": [ | |||
There was a problem hiding this comment.
These package.json files are now just sorted alphabetically, but the contents are the same.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56904 |
nicolo-ribaudo
force-pushed
the
helpers-refactor
branch
2 times, most recently
from
cf1de47
to
624ef72
Compare
nicolo-ribaudo
force-pushed
the
helpers-refactor
branch
from
624ef72
to
b98b0dc
Compare
liuxingbaoyu
approved these changes
May 16, 2024
|
In tests we mutate the |
JLHwung
approved these changes
May 16, 2024
|
I'll open a good first issue to convert the helpers to TS (in chunks) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2After this PR, since there is a build step for all helpers, I plan to move
babel/packages/babel-helpers/src/index.ts
Line 42 in 6e3539b
This PR caught a problem with our Babel7/8 integration tests: some tests fail because the helpers are missing (for example, old decorator helpers), but we didn't notice because we where generating those helpers even in Babel 8 mode during the test.