fish: performance improvments, add piping, fixes #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
type -q
calls by storing awk/filter commands in variablesWHY
Bring feature parity with zsh (piping) and improve overall latency by storing directories in memory instead of a file and freeing up execution time by moving some checks at shell init.
The existing
~/.enhancd/enhancd.log
file will be read to fill the variable if it's empty to make the migration seamless.The rewrite in
_enhancd_filter_interactive.fish
is mainly due to avoid buffering so we can takeadvantage of finders able to stream stdin, like fzf.
Simplistic benchmarks
Here are some benchmarks with the filter disabled for each version.
Log file / variable size: 345
Fish version: 3.6.1
Platform: WSL 1.3.15.0
10 runs
Command:
Results:
Latest enhancd (230695f)
perf/in-memory-logs
500 runs
Command:
Results:
Latest enhancd (230695f)
perf/in-memory-logs