Add source callback

[methyl]

Checkout.js now supports source callback: https://stripe.com/docs/checkout#required

[fantapop]

I'm trying to test out your PR however its not working for me unless I pass both a source handler and a token handler.

If I use only the token handler, it passes a token as expected to the back end.
If I use only the source handler, it fails with this error and never calls the callback

Uncaught TypeError: this.fn is not a function
    at TokenCallback.trigger (checkout.js:3)
    at TokenCallback.trigger (checkout.js:3)
    at IframeView.onToken (checkout.js:3)
    at IframeView.closed (checkout.js:3)
    at Object.closed (checkout.js:3)
    at RPC.processMessage (checkout.js:2)
    at RPC.processMessage (checkout.js:2)
    at RPC.message (checkout.js:2)
    at checkout.js:2

If I pass both a token handler and a source handler it gives this error on form load:

index.js:2178 StripeCheckout.open: The options 'source' and 'token' can not be used at the same time.
You can learn about the available configuration options in the Checkout docs:
https://stripe.com/docs/checkout

But then calls the source handler with all of the correct details after the charge.

Note that I am not the maintainer, but I am looking forward to this support. Thanks for your additions here.

[fantapop]

@methyl any ideas here?

[methyl]

@fantapop I will be updating this PR this or the next week, I know the fix already and will make sure to fix it here as well

[fantapop]

@methyl have you had an time to look at this?

[methyl]

@fantapop since I had some other issues with this lib, I just went with lazy approach and pulled it directly into my source repo. The problem is that StripeCheckout API is broken and won't allow you to pass the source callback to the open method as allows to do with the token. The solution is to pass to StripeCheckout.configure(), if you do that it will recognize the callback correctly and your error will be gone.

  updateStripeHandler(prevSource) {
    if (!this.stripeHandler || this.props.source !== prevSource) {
      this.stripeHandler = StripeCheckout.configure({
        source: this.props.source,
        key: this.props.stripeKey,
      })
    }
  }
      
  onScriptLoaded = () => {
    if (!this.stripeHandler) {
      this.stripeHandler = StripeCheckout.configure({
        key: this.props.stripeKey,
        source: this.props.source,
      })
      if (this.hasPendingClick) {
        this.showStripeDialog()
      }
    }
  }

[fantapop]

Thanks. I’ll give it a try.

…

On Fri, Oct 5, 2018 at 2:35 AM Lucjan Suski ***@***.***> wrote: @fantapop <https://github.com/fantapop> since I had some other issues with this lib, I just went with lazy approach and pulled it directly into my source repo. The problem is that StripeCheckout API is broken and won't allow you to pass the source callback to the open method as allows to do with the token. The solution is to pass to StripeCheckout.configure(), if you do that it will recognize the callback correctly and your error will be gone. updateStripeHandler(prevSource) { if (!this.stripeHandler || this.props.source !== prevSource) { this.stripeHandler = StripeCheckout.configure({ source: this.props.source, key: this.props.stripeKey, }) } } onScriptLoaded = () => { if (!this.stripeHandler) { this.stripeHandler = StripeCheckout.configure({ key: this.props.stripeKey, source: this.props.source, }) if (this.hasPendingClick) { this.showStripeDialog() } } } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#119 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGWbqFVp7Yo5by6CutOckqKBsq6OF_Blks5uhyfLgaJpZM4WlfVQ> .

[Jarvl]

Any progress on this?