Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme: PlainTasks Markdown #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ronilaukkarinen
Copy link

Ref: #244 #244

@stockerman7
Copy link

NAVER - http://www.naver.com/

[email protected] 님께 보내신 메일 <[PlainTasks] Add theme: PlainTasks Markdown (#246)> 이 다음과 같은 이유로 전송 실패했습니다.


받는 사람이 회원님의 메일을 수신차단 하였습니다.


@@ -1,4 +1,4 @@
{
bl PL{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAVER - http://www.naver.com/

[email protected] 님께 보내신 메일 <Re: [PlainTasks] Add theme: PlainTasks Markdown (#246)> 이 다음과 같은 이유로 전송 실패했습니다.


받는 사람이 회원님의 메일을 수신차단 하였습니다.


Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. Running a processor-intensive ImageOptim-task and noticed ST kinda lags, so I guess that caused it. Will fix...

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 27, 2015

It doesn’t support url scope, is it intentional? If yes, it’s okay, I just want to be sure.

It doesn’t support ST2:

error: Error loading colour scheme Packages/User/tasks-markdown.hidden-tmTheme: Error parsing plist xml: Failed to open file In file "Packages/User/tasks-markdown.hidden-tmTheme"

This is problem, we claim supprt for both ST so far (since 3 is still in beta), please ensure ST2 support, otherwise I have to reject.

@ronilaukkarinen
Copy link
Author

Not intentional and yeah, only ST3 supported for now. I was too hasty, so feel free to reject. Maybe getting back on to this in the future.

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 27, 2015

@ronilaukkarinen I’m sorry, it is my mistake, it does support ST2 just fine, the reason for error is that I set wrong path (User instead of PlainTasks).

So if you want to add url scope, just go ahead, then ping me, and it’s good to merge.

@ronilaukkarinen
Copy link
Author

@vovkkk Ok, thanks for clarifying that, I don't have ST2 installed myself so wasn't sure. I'll add the url scope in some point and get back on this.

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 27, 2015

Ooh, also there are bold and italic scopes, if you’ve missed them.

@ronilaukkarinen
Copy link
Author

Do you have a certain spec which scopes are needed? because I have created the scheme based on MarkdownEditing theme so I'm exactly not quite sure what else might be missing.

@vovkkk
Copy link
Collaborator

vovkkk commented Aug 27, 2015

        meta.tag.todo
        notes.todo
        punctuation.definition.bullet.completed
        punctuation.definition.bullet.pending
        punctuation.definition.bullet.cancelled
        meta.item.todo.cancelled
        meta.tag.todo.completed
        meta.tag.todo.cancelled
        meta.punctuation.archive.todo
        meta.punctuation.separator.todo
        punctuation.definition.italic
        todo.italic
        punctuation.definition.bold
        todo.bold
        todo.url
        string.other.tag.todo.today
        string.other.tag.todo.high
        string.other.tag.todo.low
        string.other.tag.todo.critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants