fix(Ulduar/Tram): add rocket booster, turnaround visuals, button logic

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

drawing of tram structure, ids - guids

I used timings to get the visual effects to sync up however the StaticTransport events for arrival should be used, but I can't get them to emit? I tried the following

-- 1: event_scripts to activate the "doors" circles upon arrival
DELETE FROM `event_scripts` WHERE `id` IN (21393,21394);
INSERT INTO `event_scripts` (`id`, `delay`, `command`, `datalong`, `datalong2`, `dataint`, `x`, `y`, `z`, `o`)
VALUES
(21393, 0, 11, 42867, 0, 0, 0.0, 0.0, 0.0, 0.0),
(21394, 0, 11, 56125, 0, 0, 0.0, 0.0, 0.0, 0.0);
-- 2: smartAI on the tram to activate the "doors" circles upon arrival
DELETE FROM `smart_scripts` WHERE (`source_type` = 1 AND `entryorguid` = 194675);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(194675, 1, 0, 0, 71, 0, 100, 0, 21394, 0, 0, 0, 0, 0, 9, 0, 0, 0, 0, 0, 0, 14, 56125, 194913, 0, 0, 0, 0, 0, 0, 'Tram - On Event 21393 Inform - Activate Gameobject'),
(194675, 1, 1, 0, 71, 0, 100, 0, 21393, 0, 0, 0, 0, 0, 9, 0, 0, 0, 0, 0, 0, 14, 42879, 194915, 0, 0, 0, 0, 0, 0, 'Tram - On Event 21394 Inform - Activate Gameobject');

3: ProcessEvent in instancescript

AddPassenger is called onPlayerEnter, not sure where else to do this

Issues Addressed:

• Closes (Instance/Ulduar): Ulduar Tram button does not stay with the transport. #16093
• Closes (Instance/Ulduar): The Call Tram buttons are always interactable and don't play an animation when used. #16105
• Closes (Instance/Ulduar): Missing visual effect under the Ulduar Tram when it is turned around. #16106
• Closes (Instance/Ulduar): Missing visual effect when Ulduar Tram is moving. #16107

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

The rocket booster position was present in DB as relative to the Tram object.
"Activate Tram" object

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

tram.mp4

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

tp to the tram at center

1. .go xyz 2275 288 419.3 603 0.067

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[heyitsbench]

Based on your provided video, looks quite well done! 🥳

[PkllonG]

Tested eecfd7b