Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoid duplicated exports #161

Merged
merged 2 commits into from
May 24, 2024

Conversation

rodrigo1991
Copy link
Contributor

Pull Request Template

PR Checklist

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • I have added/updated documentation for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

This pull request removes duplicated code that was not marking the 3 typed parameter iif with 2 arguments as deprecated. iif was completely marked as deprecated, this pr solves it

@rodrigo1991 rodrigo1991 requested a review from a team as a code owner May 22, 2024 11:26
Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franher franher changed the title Fix/repeated code fix(core): avoid duplicated exports May 24, 2024
@franher franher merged commit b3c8740 into axa-group:main May 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants