Made the name of environment variables consistent through benchmarking doc #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
reviewed
Feb 8, 2024
doc/BENCHMARKING.md
Outdated
| @@ -32,12 +32,12 @@ You can use the following steps. | |||
| --fuse-version 2 \ | |||
| --with-fio --with-libunwind | |||
|
|
|||
| 2. Set environment variables related to the benchmark. There are four required environment variables you need to set in order to run the benchmark. | |||
| 2. Set environment variables related to the benchmark. There are four required environment variables you need to set in order to run the benchmark. These variables can be set to any name, but be consistent with it in subsequent steps. | |||
There was a problem hiding this comment.
Should we change these steps to first create the files needed and then populate the env variables?
Also, on line 45, there is a DOC-EXAMPLE-BUCKET which is undefined. Please add that to the set of variables to set.
There was a problem hiding this comment.
Yes. That seems more reasonable. Making the change. Thanks
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
force-pushed
the
update_benchmark_documentation
branch
from
486b350
to
6336ab6
Compare
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
added 2 commits
February 9, 2024 16:55
…g doc Signed-off-by: Ankit Saurabh <[email protected]>
Signed-off-by: Ankit Saurabh <[email protected]>
sauraank
force-pushed
the
update_benchmark_documentation
branch
from
6336ab6
to
2f38025
Compare
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sauraank
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
reviewed
Feb 16, 2024
Comment on lines
+50
to
+53
| export S3_BUCKET_NAME=DOC-EXAMPLE-BUCKET | ||
| export S3_BUCKET_TEST_PREFIX=benchmark/ | ||
| export S3_BUCKET_BENCH_FILE=bench100GB.bin | ||
| export S3_BUCKET_SMALL_BENCH_FILE=bench5MB.bin |
There was a problem hiding this comment.
I think step 2 should be creating those variables (what is now in step 3). Then, step 3 can refer to those variables (what is now in step 2).
There was a problem hiding this comment.
These environment variables are to run the benchmark script that we run in step 4. We earlier thought that these environment variables should be set once we have created the resource: #740 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In our Benchmarking doc, the names for environment variables
S3_BUCKET_NAME,S3_BUCKET_TEST_PREFIX,S3_BUCKET_BENCH_FILEandS3_BUCKET_SMALL_BENCH_FILEacross steps. This might create confusion for new user trying to run benchmark.Made the names consistent across the steps for environment variables in used in benchmarking.
Relevant issues:
NA
Does this change impact existing behavior?
No. Just documentation edits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).