Update --profile flag to override default chain's profile rather than replacing default chain
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Carl Jones <[email protected]>
…ather than replacing default chain entirely Signed-off-by: Daniel Carl Jones <[email protected]>
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
changed the title
--profile flag to override default chain's profile rather than replacing default chain
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
|
Opened #685 to address crate builds issue. |
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
A previous PR was open for this change but was very stale: #415.
This change means that a profile can be specified that does not configure any credentials, but may configure other things. Mountpoint does not read any configuration from an AWS Profile other than credentials today but may do in the future.
Before this change, the entire credential chain was replaced with one that would supply profile credentials or error - no fallback. This was not in line with AWS CLI or SDKs.
This should fix #389 since the default chain also allows credential process credentials to be used.
Does this change impact existing behavior?
Yes, it fixes the behavior of the
--profile <AWS_PROFILE>flag to be in line withAWS_PROFILEenvironment variable, as well as--profile <AWS_PROFILE>flag of the AWS CLI.It also fixes bug #389.
Note: It does not validate that the AWS profile exists, like the AWS CLI does. If the profile does not exist, the parameter will be ignored. Mountpoint already behaves this way today when using the
AWS_PROFILEenvironment variable. Mountpoint previously reporting an error was a side effect of replacing the default chain with a profile provider.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).