Add unit test for setting server cipher preferences in the CH callback #4550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds a new unit test for changing server cipher preferences in the ClientHello callback
From the documentation of s2n_client_hello_fn:
Within this callback, are calls to
s2n_connection_set_cipher_preferences
also valid? I found no documentation or unit test that confirms this, so I'm contributing one under the premise that this is the case.Testing
I confirmed that removing the
s2n_connection_set_cipher_preferences()
call from the test callback fails the new unit test.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.