Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add key preferences to rfc9151 policy #4540

Merged
merged 5 commits into from
May 14, 2024

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented May 2, 2024

Resolved issues:

#4294

Description of changes:

This updates the RFC9151 named policy to include key preferences and also apply to local certificates. This is a behavior change.

current behavior

  • certs received over the wire must use a specified certificate signature preference
  • roots of trust must use a specified certificate signature preference

new additional behaviors

  • certs received over the wire must use a specified certificate key preference
  • roots of trust must use a specified certificate key preference
  • certs loaded on a config must use a specified certificate signature preference
  • certs loaded on a config must use a specified certificate key preference

Call-outs:

This PR also includes some unit test cleanup now that we can directly use the RFC9151 policy.

Testing:

All existing CI should pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label May 2, 2024
@jmayclin jmayclin marked this pull request as ready for review May 2, 2024 23:09
tls/s2n_certificate_keys.c Outdated Show resolved Hide resolved
tls/s2n_certificate_keys.c Outdated Show resolved Hide resolved
jmayclin and others added 2 commits May 3, 2024 13:01
Co-authored-by: Lindsay Stewart <[email protected]>
- add rsa pss key prefs
@jmayclin jmayclin enabled auto-merge (squash) May 14, 2024 00:45
@jmayclin jmayclin merged commit 15311dc into aws:main May 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants