Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Add auth header and upgrade SSL version to sslv23 #541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rustamserg
Copy link

Issue:
It is not possible to provide Authorization header to setup secure access into websocket gateway exposed to public internet.
Generic TLS version 1 is not accepted by modern nginx setup so changed it into sslv23.

Description of changes:
These changes are made to keep diff as small as possible to show places where gem's clients need modifications. It is not a good idea to take it as is but it is good starting point to understand what should be exposed via public gem bus.
So it would be awesome to have possibilities to add own headers and configure SSL/TLS versions for secure connections.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AMZN-nggieber
Copy link

@rustamserg Thank you for the PR, well look into your starting point and investigate implementing some of your suggestions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants