This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
EMotionFX crash when used with replication #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an uninitialized variable in an EmotionFX component. (m_animGraphInstance) This variable will cause a crash, especially in a replicated situation where Activate is not called on this component - as it doesn't use a weak pointer container. m_animGraphInstance needs to be set to null before being used - otherwise, the pointer will be considered valid memory as it's set to a non-null, garbage memory value by default.
|
Thanks for the fix! I’ll pass this to the character team for review :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Fixes an uninitialized variable in an EmotionFX component. (m_animGraphInstance)
This variable will cause a crash, especially in a replicated situation where Activate is not called on this component - as it doesn't use a weak pointer container.
m_animGraphInstance needs to be set to null before being used - otherwise, the pointer will be considered valid memory as it's set to a non-null, garbage memory value by default.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.