Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Wrong PhysX scene query buffer size #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wrong PhysX scene query buffer size #522

wants to merge 1 commit into from

Conversation

m9co
Copy link

@m9co m9co commented Sep 28, 2020

When performing scene query with more requested hits than maximum buffer size, passed buffer size (request.m_maxResults) will be lower than actual buffer size and may cause crashes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

When performing scene query with more requested hits than maximum buffer size, passed buffer size (request.m_maxResults) will be lower than actual buffer size and may cause crashes.
@AMZN-alexpete
Copy link

Thanks for submitting this fix @m9co, we're looking into integrating this.

@SergeyAMZN
Copy link

Hello @m9co ! We've reviewed your pull request and wanted to let you know we will be incorporating your proposed changes into our next version of the Lumberyard engine. Thank you kindly for contributing to Lumberyard!

@theblooopz
Copy link

theblooopz commented Nov 10, 2020

You should tag and close PRs you integrate. So that we know which are added and which aren't.

@m9co
Copy link
Author

m9co commented Nov 10, 2020

@wcbx should I be doing that with my PRs?

@theblooopz
Copy link

@m9co you can do what you want with your branch. I was saying Amazon should close this if they integrated it or at least tag it as integrated. Ideally they would do both.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants