fix(jsii-pacmak): improve struct performance in Java #4140
+1,480
−773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a struct is returned to Java, it gets returned by reference. The Java struct proxy then proceeds to read all fields from the struct, even if they are never used by the Java program. Make this behavior on-demand with a cache: the value is read if it is requested, but will never be read more than once (this is fine as structs are immutable). If we decide to pass the struct back into jsii, we can avoid having to read all the fields at that point to build a fresh struct if we hold on to the struct reference and pass that back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a struct is returned to Java, it gets returned by reference. The Java struct proxy then proceeds to read all fields from the struct, even if they are never used by the Java program.
Make this behavior on-demand with a cache: the value is read if it is requested, but will never be read more than once (this is fine as structs are immutable).
If we decide to pass the struct back into jsii, we can avoid having to read all the fields at that point to build a fresh struct if we hold on to the struct reference and pass that back in.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.