Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubelet configuration for control plane and worker nodes - vsphere #8179

Closed
wants to merge 2 commits into from

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented May 20, 2024

Issue #, if available:

Description of changes:
This PR adds a new field KubeletConfiguration in the eksa spec for control plane and worker node configuration. This is an unstructured object that is of the kind value KubeletConfiguration. This PR adds the code for vSphere provider.

Testing (if applicable):

  • unit tests
  • e2e tests

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2024
@mitalipaygude mitalipaygude added do-not-merge/work-in-progress and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.42%. Comparing base (249f20d) to head (37504b3).

Files Patch % Lines
pkg/providers/vsphere/template.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8179      +/-   ##
==========================================
- Coverage   73.42%   73.42%   -0.01%     
==========================================
  Files         577      577              
  Lines       35944    35957      +13     
==========================================
+ Hits        26391    26400       +9     
- Misses       7884     7886       +2     
- Partials     1669     1671       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitalipaygude mitalipaygude changed the title Add Kubelet configuration for control plane and worker nodes Add Kubelet configuration for control plane and worker nodes - vsphere May 20, 2024
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress labels May 20, 2024
@mitalipaygude mitalipaygude force-pushed the kubelet-config branch 4 times, most recently from 5a44b26 to a3b67ca Compare May 24, 2024 23:00
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2024
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants