feat: support importing internal ALBs for backend services #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍕 Here are the new binary sizes!
|
iamhopaul123
reviewed
Dec 1, 2023
internal/pkg/cli/deploy/backend.go
Outdated
Comment on lines
166
to
168
| if len(alb.Listeners) == 0 || len(alb.Listeners) > 2 { | ||
| return fmt.Errorf(`imported ALB %q must have either one or two listeners`, alb.ARN) | ||
| } |
There was a problem hiding this comment.
Users might get confused about what to do when they see this error msg. Maybe we should
- return when they just have 1 listener
- check if they have exactly one http listener and one https listener. if not we error out.
There was a problem hiding this comment.
changed! not sure if this is any better...lmk!
| @@ -596,7 +596,7 @@ func (o *deploySvcOpts) uriRecommendedActions() ([]string, error) { | |||
| case describe.URIAccessTypeServiceDiscovery: | |||
| network = "with service discovery." | |||
internal/pkg/template/templates/workloads/services/backend/cf.yml
Outdated
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
Related: #5490. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
iamhopaul123
added
do-not-merge
iamhopaul123
added
do-not-merge
KollaAdithya
added
do-not-merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #5490 +/- ##
============================================
- Coverage 70.01% 69.99% -0.02%
============================================
Files 303 303
Lines 46638 46714 +76
Branches 299 299
============================================
+ Hits 32655 32699 +44
- Misses 12396 12424 +28
- Partials 1587 1591 +4 ☔ View full report in Codecov by Sentry. |
KollaAdithya
added
do-not-merge
iamhopaul123
approved these changes
Apr 16, 2024
huanjani
added
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5438.
Integ test changes in #5483.
#5483 adds the Load Balancer DNS name to the service as an env var (and therefore appears in
svc showoutput. However, it is not (yet) included in URI output as a recommended action insvc deployoutput.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.