Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add primary keys when upserting in Postgres #2819

Merged
merged 4 commits into from
May 15, 2024
Merged

fix: add primary keys when upserting in Postgres #2819

merged 4 commits into from
May 15, 2024

Conversation

AntonMantulo
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Fixes issue with table creation when using upsert mode in Postgres.

@AntonMantulo AntonMantulo mentioned this pull request May 13, 2024
Closed
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
kukushking
kukushking approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Do you mind adding a test case as well, please?

@kukushking kukushking linked an issue May 14, 2024 that may be closed by this pull request
Postgres upsert table creation #2818
Closed
@AntonMantulo
Copy link
Contributor Author

Sure, no problem.

Anton Mantulo added 2 commits May 15, 2024 13:56
@AntonMantulo
Copy link
Contributor Author

There was the same problem when using append mode alongside insert_conflict_columns, added a fix for that. Additionally, removed some statements in tests that led to false positives.

@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 9a4cace
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 9a4cace
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit b3f215e into aws:main May 15, 2024
17 checks passed
@AntonMantulo AntonMantulo deleted the fix/upsert-postgres-table-creation branch May 16, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres upsert table creation
4 participants
@AntonMantulo @malachi-constant @kukushking @LeonLuttenberger