Codegen refactoring for operation context params and jmesPath #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interceptor code
cenedhryn
changed the title
cenedhryn
changed the title
|
zoewangg
approved these changes
May 14, 2024
| /** | ||
| * Knowledge index to get access to operation context parameters. | ||
| */ | ||
| public final class OperationContextParamsKnowledgeIndex { |
There was a problem hiding this comment.
Nit: KnowledgeIndex sounds fancy, but I don't know what it means😅. Maybe just OperationContextParamsHelper?
There was a problem hiding this comment.
It's not my favorite either, but there is prior art from the SRA implementation and I'd rather not introduce a new term right now. We could rename all the KnowledgeIndex instances in a separate PR.
There was a problem hiding this comment.
Ah I see, we have more Helper classes than KnowledgeIndex classes though ;) Anyway, it's codegen class, so it doesn't really matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Refactors codegen for operation context parameters and jmesPath code generator, and fixes the condition for when to generate the jmesPath runtime.
Modifications
EndpointResolverInterceptorSpecis getting too big. By extracting logic and codegen for Operation Context Params and putting into a separate class, it's easier to read and understand the codeJmesPathAcceptorGeneratortoJmesPathExpressionConvertersinceAcceptoris a Waiter term. Another name could beJmesPathCodeGeneratorJmesPathRuntime.java.resourcewas set to true. Now that all endpoint parameter logic is finished, it's updated to checking for the presence of Operation Context Params: If there are waiters, we know there is a runtime. If there are no waiters, we'll generate runtime if there are operation context parametersTesting
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License