Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reload credentials not working when modified #5185

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix reload credentials not working when modified #5185

wants to merge 9 commits into from

Conversation

munendrasn
Copy link

@munendrasn munendrasn commented May 6, 2024 •
edited

Ensure defaultSupplier is used instead of fixedSupplier in case of defaultProfileFile.

I have updated the some places where defaultProfileFile was used along with fixedProfileSupplier with defaultSupplier

Motivation and Context

Fixes #4268

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@munendrasn munendrasn requested a review from a team as a code owner May 6, 2024 16:22
@munendrasn
Copy link
Author

@debora-ito @millems Please review, tagging you as changes includes to area that were updated by you recently. Please let me know if approach need to be modified

@debora-ito debora-ito added needs-review This issue or PR needs review from the team. and removed needs-review This issue or PR needs review from the team. labels May 15, 2024
anirudh9391
anirudh9391 reviewed May 23, 2024
View reviewed changes
...k-core/src/main/java/software/amazon/awssdk/core/client/builder/SdkDefaultClientBuilder.java Outdated
@@ -252,7 +253,8 @@ protected SdkClientConfiguration mergeChildDefaults(SdkClientConfiguration confi
* Apply global default configuration
*/
private SdkClientConfiguration mergeGlobalDefaults(SdkClientConfiguration configuration) {
Supplier<ProfileFile> defaultProfileFileSupplier = new Lazy<>(ProfileFile::defaultProfileFile)::getValue;
Supplier<ProfileFileSupplier> profileFileSupplierSupplier = new Lazy<>(ProfileFileSupplier::defaultSupplier)::getValue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : can we name this something like profileFileSupplierProvider instead of the double "Supplier" ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed the variable

@munendrasn
Copy link
Author

CI build failure seems to be unrelated to the PR, it is failing while setting the aws credentials. Please let me know if any setup or changes required

@munendrasn
Copy link
Author

@anirudh9391 the CI build is failing in the setup.. please let me know if anything can be done to resolve it

@munendrasn
Copy link
Author

Based on findings, the secrets apart from GITHUB_TOKEN is not available to PR from forked repository. actions/runner#3039

I don't have access to push the branch to this repository. @anirudh9391 would it be possible to pick these changes & create branch in this repo?

@anirudh9391
Copy link
Contributor

Based on findings, the secrets apart from GITHUB_TOKEN is not available to PR from forked repository. actions/runner#3039

I don't have access to push the branch to this repository. @anirudh9391 would it be possible to pick these changes & create branch in this repo?

Yeah I can do that

@anirudh9391 anirudh9391 mentioned this pull request May 31, 2024
Open
initialise the fallback profile file with empty aggregator
d7cd3a0 
ProfileFile's builder expects contentLocation or content to be present.
Here, ProfileFile is being used as fallback, ensure it doesn't fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudh9391 anirudh9391 anirudh9391 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@anirudh9391 anirudh9391

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credentials reloading is not working in the recent versions (2.20.x)
3 participants
@munendrasn @anirudh9391 @debora-ito