Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KMS encryption context for S3 transfer commands #8585

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

robbie-demuth
Copy link

@robbie-demuth robbie-demuth commented Mar 20, 2024

Description of changes:

Supports KMS encryption context for S3 transfer commands (s3 sync, s3 cp, and s3 mv)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -218,6 +218,19 @@
}


SSE_KMS_ENCRYPTION_CONTEXT = {
'name': 'sse-kms-encryption-context',
'help_text': (
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the help text for the --ssekms-encryption-context arg for the s3api put-object command

request_params['SSEKMSKeyId'] = cli_params['sse_kms_key_id']
if cli_params.get('sse_kms_encryption_context'):
request_params['SSEKMSEncryptionContext'] = cli_params['sse_kms_encryption_context']
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbie-demuth
Copy link
Author

@kdaily and/or @kyleknap, mind giving this a review? First time contributor here, so feel free to redirect me if I'm not following the process correctly. I took a look at the contributing guide and didn't see anything about requesting reviews. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant