Allow configuring local IP for ec2-instance-connect open-tunnel. #8488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IP used for ec2-instance-connect open-tunnel was hard-coded to localhost. This means that it does not work for users of the AWS CLI Docker image, because Docker can only expose services that listen on 0.0.0.0. This PR adds an option --local-ip, consistent with --local-port, which allows the user to override the IP that the tunnel is bound to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP used for ec2-instance-connect open-tunnel was hard-coded to localhost. This means that it does not work for users of the AWS CLI Docker image, because Docker can only expose services that listen on 0.0.0.0.
This PR adds an option --local-ip, consistent with --local-port, which allows the user to override the IP that the tunnel is bound to.
Issue #, if available: N/A
Description of changes:
--local-ipCLI flag toopen-tunnelcommandWebsocketManagerI could not find instructions for running tests, so I did not add a test. I did do a manual sanity check to ensure that it worked as I thought it would.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.