-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace magic strings with constants #8453
Closed
Closed
Commits on Dec 22, 2023
-
The doc_option method was previously handling mutliple responsibiliti…
…es including documenting argument groups, individual arguments, adding notes, and documenting models, which made the method quite large and cumbersome. To improve this, I refactored the method into smaller and more manageable methods which handle a single responsibility.
Configuration menu - View commit details
-
Copy full SHA for e3c3f6e - Browse repository at this point
Copy the full SHA e3c3f6eView commit details -
In the existing code, we had severalstring constants defined with the…
… HelpCommandDocumentEventHandler class. They included 'Description','Synopsis', 'Options', and 'Output'. To improve this, I defined these constants globally at the top of each classes, such that if we need to change any of these constants in the future, we can do it in one place and the changes will propagate throughout the code
Configuration menu - View commit details
-
Copy full SHA for 3d34d2f - Browse repository at this point
Copy the full SHA 3d34d2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9295376 - Browse repository at this point
Copy the full SHA 9295376View commit details -
Add error handling to register method by placing the try/except block…
… aroud the _map_handlers, now errors will be handled gracefully
Configuration menu - View commit details
-
Copy full SHA for 8bbe6e1 - Browse repository at this point
Copy the full SHA 8bbe6e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 210890f - Browse repository at this point
Copy the full SHA 210890fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6ef088 - Browse repository at this point
Copy the full SHA d6ef088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41c6707 - Browse repository at this point
Copy the full SHA 41c6707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f940db - Browse repository at this point
Copy the full SHA 8f940dbView commit details -
Revert "Refactor repeated code into get_don method"
This reverts commit 8f940db.
Configuration menu - View commit details
-
Copy full SHA for ba5f0fa - Browse repository at this point
Copy the full SHA ba5f0faView commit details -
Configuration menu - View commit details
-
Copy full SHA for f94b58a - Browse repository at this point
Copy the full SHA f94b58aView commit details
Commits on Dec 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 354aea0 - Browse repository at this point
Copy the full SHA 354aea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for be9f812 - Browse repository at this point
Copy the full SHA be9f812View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6556a - Browse repository at this point
Copy the full SHA ed6556aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8194f68 - Browse repository at this point
Copy the full SHA 8194f68View commit details -
Configuration menu - View commit details
-
Copy full SHA for d04d390 - Browse repository at this point
Copy the full SHA d04d390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32cc27f - Browse repository at this point
Copy the full SHA 32cc27fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dbcf70 - Browse repository at this point
Copy the full SHA 3dbcf70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23a8d46 - Browse repository at this point
Copy the full SHA 23a8d46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d82b45 - Browse repository at this point
Copy the full SHA 6d82b45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43a6dd4 - Browse repository at this point
Copy the full SHA 43a6dd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ee7c39 - Browse repository at this point
Copy the full SHA 0ee7c39View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f3720 - Browse repository at this point
Copy the full SHA a2f3720View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce81210 - Browse repository at this point
Copy the full SHA ce81210View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf4e8d1 - Browse repository at this point
Copy the full SHA bf4e8d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eac3e92 - Browse repository at this point
Copy the full SHA eac3e92View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8055d3 - Browse repository at this point
Copy the full SHA b8055d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 555c5c1 - Browse repository at this point
Copy the full SHA 555c5c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2df0e58 - Browse repository at this point
Copy the full SHA 2df0e58View commit details -
Configuration menu - View commit details
-
Copy full SHA for ede2937 - Browse repository at this point
Copy the full SHA ede2937View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.