Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace magic strings with constants #8453

Closed
wants to merge 29 commits into from

Commits on Dec 22, 2023

  1. The doc_option method was previously handling mutliple responsibiliti…

    …es including documenting argument groups, individual arguments, adding notes, and documenting models, which made the method quite large and cumbersome. To improve this, I refactored the method into smaller and more manageable methods which handle a single responsibility.
    Sergius-Nyah committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    e3c3f6e View commit details
    Browse the repository at this point in the history
  2. In the existing code, we had severalstring constants defined with the…

    … HelpCommandDocumentEventHandler class. They included 'Description','Synopsis', 'Options', and 'Output'. To improve this, I defined these constants globally at the top of each classes, such that if we need to change any of these constants in the future, we can do it in one place and the changes will propagate throughout the code
    Sergius-Nyah committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    3d34d2f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9295376 View commit details
    Browse the repository at this point in the history
  4. Add error handling to register method by placing the try/except block…

    … aroud the _map_handlers, now errors will be handled gracefully
    Sergius-Nyah committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    8bbe6e1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    210890f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d6ef088 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    41c6707 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8f940db View commit details
    Browse the repository at this point in the history
  9. Revert "Refactor repeated code into get_don method"

    This reverts commit 8f940db.
    Sergius-Nyah committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    ba5f0fa View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f94b58a View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Configuration menu
    Copy the full SHA
    354aea0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be9f812 View commit details
    Browse the repository at this point in the history
  3. Remove unused parameters

    Sergius-Nyah committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    ed6556a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8194f68 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d04d390 View commit details
    Browse the repository at this point in the history
  6. Make AWS_DOC_BASE global

    Sergius-Nyah committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    32cc27f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3dbcf70 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    23a8d46 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6d82b45 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    43a6dd4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0ee7c39 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a2f3720 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ce81210 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bf4e8d1 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    eac3e92 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b8055d3 View commit details
    Browse the repository at this point in the history
  17. idna Doctring

    Sergius-Nyah committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    555c5c1 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2df0e58 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ede2937 View commit details
    Browse the repository at this point in the history