Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
@attribute
might not be appropriate since it's derived from the resource ref, a maintainer should weigh in on thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it helps, the exemple construct from the coding guideline uses
@attribute
for the ARN property even if it is computed manually (like in this case) :exempleResourceArn
is tagged with@attribute
aws-cdk/packages/@aws-cdk/example-construct-library/lib/example-resource.ts
Lines 70 to 83 in 6fdc458
exempleResourceArn
is constructed manually infrom
static methods and constructoraws-cdk/packages/@aws-cdk/example-construct-library/lib/example-resource.ts
Lines 362 to 368 in 6fdc458
The only doubt I have is regarding this precision :
It needs to be annotated with '@attribute' if the underlying CloudFormation resource surfaces the ARN as a return value.
CloudFormation does not surface
AWS::SES::ConfigurationSet
ARN.