chore(release): v2.139.1 (#30007)

See CHANGELOG
aws · Apr 30, 2024 · b88f959 · b88f959
2 parents 2699ffd + 3ff013b
commit b88f959
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 41 deletions.
diff --git a/CHANGELOG.v2.alpha.md b/CHANGELOG.v2.alpha.md
@@ -2,6 +2,8 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [2.139.1-alpha.0](https://github.com/aws/aws-cdk/compare/v2.139.0-alpha.0...v2.139.1-alpha.0) (2024-04-29)
+
 ## [2.139.0-alpha.0](https://github.com/aws/aws-cdk/compare/v2.138.0-alpha.0...v2.139.0-alpha.0) (2024-04-24)
 
 ## [2.138.0-alpha.0](https://github.com/aws/aws-cdk/compare/v2.137.0-alpha.0...v2.138.0-alpha.0) (2024-04-18)

diff --git a/CHANGELOG.v2.md b/CHANGELOG.v2.md
@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [2.139.1](https://github.com/aws/aws-cdk/compare/v2.139.0...v2.139.1) (2024-04-29)
+
+
+### Reverts
+
+* fix(lambda): version.fromVersionArn creates invalid Version object ([#30003](https://github.com/aws/aws-cdk/issues/30003)) ([ced7a46](https://github.com/aws/aws-cdk/commit/ced7a46b45aeee335264d91cf8287da4837dbab8))
+
 ## [2.139.0](https://github.com/aws/aws-cdk/compare/v2.138.0...v2.139.0) (2024-04-24)
 
 

diff --git a/packages/aws-cdk-lib/aws-lambda/lib/function.ts b/packages/aws-cdk-lib/aws-lambda/lib/function.ts
@@ -671,18 +671,7 @@ export class Function extends FunctionBase {
  * in the same account and region as the stack you are importing it into.
  */
  public static fromFunctionArn(scope: Construct, id: string, functionArn: string): IFunction {
- /**
- * If the functionArn has a trailing version or alias (more than 7 parts when split by ":",
- * we trim off the trailing version/alias to retrieve the real functionArn.
- * See lambda resource ARN format here: https://docs.aws.amazon.com/lambda/latest/dg/lambda-api-permissions-ref.html
- */
- const parts = functionArn.split(':');
- if (parts.length > 7) {
- const _functionArn = parts.slice(0, 7).join(':');
- return Function.fromFunctionAttributes(scope, id, { functionArn: _functionArn });
- } else {
- return Function.fromFunctionAttributes(scope, id, { functionArn });
- }
+ return Function.fromFunctionAttributes(scope, id, { functionArn });
  }
 
  /**

diff --git a/packages/aws-cdk-lib/aws-lambda/test/function.test.ts b/packages/aws-cdk-lib/aws-lambda/test/function.test.ts
@@ -397,30 +397,6 @@ describe('function', () => {
  expect(imported.functionName).toEqual('ProcessKinesisRecords');
  });
 
- test('fromFunctionArn with verionArn as the input', () => {
- // GIVEN
- const stack2 = new cdk.Stack();
-
- // WHEN
- const imported = lambda.Function.fromFunctionArn(stack2, 'Imported', 'arn:aws:lambda:us-east-1:123456789012:function:ProcessKinesisRecords:1');
-
- // THEN
- expect(imported.functionArn).toEqual('arn:aws:lambda:us-east-1:123456789012:function:ProcessKinesisRecords');
- expect(imported.functionName).toEqual('ProcessKinesisRecords');
- });
-
- test('fromFunctionArn with trailing alias as the input', () => {
- // GIVEN
- const stack2 = new cdk.Stack();
-
- // WHEN
- const imported = lambda.Function.fromFunctionArn(stack2, 'Imported', 'arn:aws:lambda:us-east-1:123456789012:function:ProcessKinesisRecords:TEST');
-
- // THEN
- expect(imported.functionArn).toEqual('arn:aws:lambda:us-east-1:123456789012:function:ProcessKinesisRecords');
- expect(imported.functionName).toEqual('ProcessKinesisRecords');
- });
-
  test('Function.fromFunctionName', () => {
  // GIVEN
  const stack = new cdk.Stack();

diff --git a/packages/aws-cdk-lib/aws-lambda/test/lambda-version.test.ts b/packages/aws-cdk-lib/aws-lambda/test/lambda-version.test.ts
@@ -15,9 +15,6 @@ describe('lambda version', () => {
  // WHEN
  const version = lambda.Version.fromVersionArn(stack, 'Version', 'arn:aws:lambda:region:account-id:function:function-name:version');
 
- expect(version.version).toStrictEqual('version');
- expect(version.lambda.functionArn).toStrictEqual('arn:aws:lambda:region:account-id:function:function-name');
-
  new cdk.CfnOutput(stack, 'ARN', { value: version.functionArn });
  new cdk.CfnOutput(stack, 'Name', { value: version.functionName });
 

diff --git a/version.v2.json b/version.v2.json
@@ -1,4 +1,4 @@
 {
- "version": "2.139.0",
- "alphaVersion": "2.139.0-alpha.0"
+ "version": "2.139.1",
+ "alphaVersion": "2.139.1-alpha.0"
 }