Add SKLearn and SparkML registries #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally log in to the appropriate ECR accounts for public SKLearn and Spark ML images in the current AWS_DEFAULT_REGION. Stop-gap for missing containers mentioned in aws-samples#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Stop-gap for missing containers mentioned in #13, but doesn't provide the requested CLI input feature
Description of changes:
Conditionally log in to the appropriate ECR accounts for public SKLearn and SparkML images in the current
AWS_DEFAULT_REGION, as listed in the SageMaker docs hereI figured it would be better to add the extra registries conditionally by region, since there are so many?
Testing done:
I patched the updated buildspec template into my
pip installed version of the library and it enabled me to successfully build the container I was stuck on - but of course haven't been able to fully go and validate the registries for the many different regions!By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.