Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cur proxy #807

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Cur proxy #807

wants to merge 20 commits into from

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@petrokashlikov petrokashlikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted few comments. Also wasn't able to understand full logic as of now.

Copy link
Contributor

@petrokashlikov petrokashlikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more questions/comments

cid/helpers/cur_proxy.py Dismissed Show dismissed Hide dismissed
'account_status': account.get('Status'), #Only for Trends
'account_email': account.get('Email'), #Only for Trends
})
for account in orgs.get_paginator('list_accounts').paginate().search('Accounts'):

Check notice

Code scanning / CodeGuru Reviewer Scanner

Violation of PEP8 programming recommendations Low

To create a list, try to use list comprehension instead of a loop. List comprehension is the preferred way to make a list using Python, and it's simpler and easier to understand than using a loop.

Learn more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants