Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: RAG langchain library and methods #245

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update: RAG langchain library and methods #245

wants to merge 4 commits into from

Conversation

ekuongm
Copy link

@ekuongm ekuongm commented Apr 26, 2024

Updated deprecated methods from Langchain library

  • Bedrock class on langchain
  • retriever get_relevant_documents method

rsgrewal-aws
rsgrewal-aws reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@rsgrewal-aws rsgrewal-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm if we need 0.1.10 or can it work with the latest langchain version ?

rsgrewal-aws
rsgrewal-aws requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@rsgrewal-aws rsgrewal-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please adjust the Read me file in this section and also summit the change in the workshop studio .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsgrewal-aws rsgrewal-aws rsgrewal-aws requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekuongm @rsgrewal-aws