Fix sample code and add claude v3 code generation #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chpecora
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Could you add a note about the messages API vs text completion API being used to invoke the model in the Claude 2 vs Claude 3 sections, highlighting why that body structure was used instead of the format used in the above Claude 2 example. i.e. Messages API is required for Claude 3 and is backward compatible with Claude 2.1 and below.
|
@chpecora Added! Is there any other points about messages API that we should be adding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 changes:
Change 1: Fixing incorrect sample code
Above result from sample generated code is incorrect. It should be 'P003' and '2023-04-23'.
The changed code is also generated from Claude v2 but it gets the result correct.
Change 2: Adding Claude v3 generated code for comparison / easy access to users who want to play with Claude v3 in this particular notebook.
Changed prompt a little bit to avoid Claude v3 from using pandas.
Claude v3 also generates desired output, so I included sample as well.