Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsx openzfs #391

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fsx openzfs #391

wants to merge 1 commit into from

Conversation

joaocc
Copy link
Contributor

@joaocc joaocc commented May 8, 2024

What does this PR do?

Initial attempt at adding support for FSx for OpenZFS

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

This is a draft PR to assess if implementation approach is good.
It currently has the option for 2 alternatives for permissions (from https://github.com/kubernetes-sigs/aws-fsx-openzfs-csi-driver/blob/main/docs/install.md#set-up-driver-permissions):

  1. arn:aws:iam::aws:policy/AmazonFSxFullAccess
  2. using example policy
    If guidance is to select only one, the code can be simplified.

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaocc thanks for the PR. Its looking good. Can you please add the following?

  1. Provide evidence on how this was tested.
  2. Add a page for docs (see other addons for examples)
  3. Fix for all CI checks that have failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable support for aws-fsx-openzfs-csi-driver
2 participants