Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more rules to v1 #3250

Merged
merged 6 commits into from
May 16, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Convert more rules to v1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.47%. Comparing base (31a7144) to head (50d8097).

Current head 50d8097 differs from pull request most recent head c8f6752

Please upload reports for the commit c8f6752 to get more accurate results.

Files Patch % Lines
src/cfnlint/template/template.py 72.72% 1 Missing and 2 partials ⚠️
src/cfnlint/rules/parameters/NoEcho.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3250      +/-   ##
==========================================
- Coverage   92.57%   92.47%   -0.10%     
==========================================
  Files         308      308              
  Lines       10640    10649       +9     
  Branches     2267     2265       -2     
==========================================
- Hits         9850     9848       -2     
- Misses        453      461       +8     
- Partials      337      340       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit b860bff into aws-cloudformation:main May 16, 2024
20 checks passed
@kddejong kddejong deleted the v1-cleanup/2024/05/14 branch May 16, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant