Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor release workflow #5092

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Nov 23, 2023

Description of changes:

Kick Off Release workflow changes

  • Change the branch name to releases/X.X.X to kick off release and bump branch
  • Change the destination branch for release PR from release to main
  • Change the commit message

Release workflow changes

  • Change the trigger to PR closed and merged.
  • Make sure the message is correct for the release.
  • Remove the update main branch step because it is no longer needed.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d
Copy link
Member

5d commented Nov 27, 2023

There are some permissions for assuming AWS OIDC roles we might need to double check.

@5d I am not sure which if I understand why permissions would affect this PR. Can you elaborate?

We might need other's help. It's about the action environment setting on branches. I remember we restrict some of them to release branch. You might need to change that to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants