fix(storage): credentials expires after 1 hour #13329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
commented
May 2, 2024
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
ashika112
reviewed
May 3, 2024
ashika112
reviewed
May 3, 2024
ashika112
reviewed
May 3, 2024
packages/storage/__tests__/providers/s3/apis/utils/resolveS3ConfigAndInput.test.ts
Outdated
Show resolved
Hide resolved
packages/storage/__tests__/providers/s3/apis/utils/resolveS3ConfigAndInput.test.ts
Outdated
Show resolved
Hide resolved
packages/storage/src/providers/s3/utils/resolveS3ConfigAndInput.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
force-pushed
the
fix-storage-upload-expire
branch
2 times, most recently
from
0ba9cf0
to
daf7a88
Compare
erinleigh90
reviewed
May 6, 2024
erinleigh90
reviewed
May 6, 2024
erinleigh90
reviewed
May 6, 2024
erinleigh90
reviewed
May 6, 2024
erinleigh90
reviewed
May 6, 2024
There was a problem hiding this comment.
Managed to orphan a good chunk of my comments, but mainly LGTM. I was just concerned about the change in functionality between toHaveBeenCalledWith and 'toBeLastCalledWithConfigAndInput` when we are not asserting the number of times we expect the function to be called in the test classes.
packages/storage/__tests__/providers/s3/apis/uploadData/putObjectJob.test.ts
Show resolved
Hide resolved
packages/storage/__tests__/providers/s3/apis/uploadData/putObjectJob.test.ts
Show resolved
Hide resolved
3 tasks
AllanZhengYP
force-pushed
the
fix-storage-upload-expire
branch
from
daf7a88
to
42c90b4
Compare
AllanZhengYP
force-pushed
the
fix-storage-upload-expire
branch
from
42c90b4
to
735af87
Compare
ashika112
approved these changes
May 16, 2024
packages/storage/__tests__/providers/s3/apis/uploadData/multipartHandlers.test.ts
Show resolved
Hide resolved
packages/storage/__tests__/providers/s3/apis/uploadData/multipartHandlers.test.ts
Show resolved
Hide resolved
|
Overall i am not against merging, but i think we should avoid type casting. Why are we casting it? We realized lotta issue because of type casts even in tests during gen2 work. Dont mind a separate followup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Supply credentials provider instead of resolved static credentials object to the S3 client. As a result, underlying S3 client can always access up-to-dated credentials. This solves the issue for credentials expiration in long-running processes like MPU
Issue #, if available
#13307
Description of how you validated changes
Manual validation
Unit test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.