Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "core" package to API package as a peerdep #12619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josefaidt
Copy link
Contributor

Description of changes

The core package is consumed by api but is not declared as a dependency in the api's package.json

https://github.com/aws-amplify/amplify-js/blob/main/packages/api/src/API.ts#L5
https://github.com/aws-amplify/amplify-js/blob/main/packages/api/package.json#L70-L74

This change modifies the dependencies of the API package to mimic its dependencies https://github.com/aws-amplify/amplify-js/blob/main/packages/api-rest/package.json#L86-L90

  • mimics dependency setup of @aws-amplify/api's dependencies: api-rest and api-graphql
  • adds @aws-amplify/core as a devDependency to @aws-amplify/api
  • adds @aws-amplify/core as a peerDependency to @aws-amplify/api

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt josefaidt marked this pull request as ready for review November 22, 2023 19:22
@josefaidt josefaidt requested review from a team as code owners November 22, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant