Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve create_dataset, video_to_slomo #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve create_dataset, video_to_slomo #60

wants to merge 2 commits into from

Conversation

tobbez
Copy link

@tobbez tobbez commented Oct 12, 2019

  • In both: Use subprocess.check_call instead of os.system. This means even file names with special characters (e.g. ") will work correctly.
  • In create_dataset: Increase the number of digits used in frame file names. The previous number would cause frames to appear out of order when using them in training if a video used for the data set had more than 9999 frames.

@tobbez
Use subprocess instead of os.system
cfb7ec8 
This removes issues caused by file names containing special characters.
@tobbez
create_dataset: Increase frame file name lengths
0b4d246 
The previous length of 4 digits would cause frames out of order if you
used a video with more than 9999 frames, e.g. a 240 fps longer than ~42
seconds.

The new length of 9 should be high enough, with good margin (allowing
for 48+ days of 240 fps video).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tobbez